- lexer.rl: handle CLRF as a line separator #1022
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1020.
A few notes:
\r\n
is a line separatorparser
still emitstNL
token with location of the\n
charactertSTRING_CONTENT
tokens now have proper locations, but the content doesn't include\r
part of\r\n
(becauseeval(%{"\r\n"})
is just"\n"
), so.source
of their locations doesn't match string content. I guess it's fine, the same happens with all escape sequences anyway.If it doesn't break Rubocop's test suite I guess it's safe to merge it as is.
@kddnewton Could you take a look at this please? Does it fix Prism's translator?