error: unexpected token kDO

[znz]

I found similar issue at rubocop/rubocop#5573, and I think this is bug of parser instead of rubocop.

% ruby-parse -v
ruby-parse based on parser version 2.5.0.2
% cat test.rb
foo "#{(1+1).to_i}" do
end
% ruby-parse test.rb
warning: parser/current is loading parser/ruby24, which recognizes
warning: 2.4.0-compliant syntax, but you are running 2.4.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
test.rb:1:21: error: unexpected token kDO
test.rb:1: foo "#{(1+1).to_i}" do
test.rb:1:                     ^~
% ruby-parse _2.4.0.2_ test.rb
warning: parser/current is loading parser/ruby24, which recognizes
warning: 2.4.0-compliant syntax, but you are running 2.4.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
(block
  (send nil :foo
    (dstr
      (begin
        (send
          (begin
            (send
              (int 1) :+
              (int 1))) :to_i))))
  (args) nil)

[whitequark]

Released 2.5.0.3 that has this fixed.

[znz]

It seems nothing changed.

% ruby-parse -v
ruby-parse based on parser version 2.5.0.3
% ruby-parse test.rb
test.rb:1:21: error: unexpected token kDO
test.rb:1: foo "#{(1+1).to_i}" do
test.rb:1:                     ^~

[whitequark]

Works for me:

$ cat test.rb
foo "#{(1+1).to_i}" do
end
$ ./bin/ruby-parse --version
ruby-parse based on parser version 2.5.0.3
$ ./bin/ruby-parse test.rb
(block
  (send nil :foo
    (dstr
      (begin
        (send
          (begin
            (send
              (int 1) :+
              (int 1))) :to_i))))
  (args) nil)

[pocke]

ruby-parse can parse it in Ruby 2.3, but it cannot parse in newer.

$ ruby -v
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
$ bin/ruby-parse test.rb
(block
  (send nil :foo
    (dstr
      (begin
        (send
          (begin
            (send
              (int 1) :+
              (int 1))) :to_i))))
  (args) nil)

$ ruby -v
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

$ bin/ruby-parse test.rb
test.rb:1:21: error: unexpected token kDO
test.rb:1: foo "#{(1+1).to_i}" do
test.rb:1:                     ^~

[dmarcoux]

Hi, this issue is still occuring with Ruby 2.5.0 and parser 2.5.0.5. To investigate, please refer to the issue linked just above my comment. You can see in Travis CI's output that parser 2.5.0.5 is really the version installed

Thank you!

[iliabylich]

I can confirm it, 2.5.0.5 fails, but master branch parses it properly. @whitequark could you cut a release please?

[dmarcoux]

Is there a way around it for now? I ask as it's blocking a pull request. It's not urgent, I'm simply curious. Thank you for confirming it so quickly.

[iliabylich]

Yes, 2.5.0.5 cannot parse any code like:

post params: "#{(DateTime.now + 1.day)}"
m(1) do

end

Basically avoid constructions like "#{(expression)}" because they leave garbage in the stack that is used to distinguish kDO and kDO_BLOCK.

So the workaround is to change the code to "#{DateTime.now + 1.day}".

[whitequark]

I'll cut a release soon.

[whitequark]

2.5.1.0