Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in compose file are not being ignored #111

Closed
whoan opened this issue Oct 20, 2022 · 0 comments · Fixed by #114
Closed

Comments in compose file are not being ignored #111

whoan opened this issue Oct 20, 2022 · 0 comments · Fixed by #114
Assignees
@whoan
Labels
bug Something isn't working

Comments

@whoan
Copy link
Owner

whoan commented Oct 20, 2022 •
edited
Loading

The action should ignore any comments in the compose after the value it need to retrieve. eg:

image: docker.pkg.github.com/whoan/hello-world/gh-2:latest # some comment here

Example of error: https://github.com/whoan/hello-world/actions/runs/3292978364/jobs/5428976456#step:5:114

Failing test: whoan/hello-world#4
@whoan whoan added the bug Something isn't working label Oct 20, 2022
@whoan whoan self-assigned this Oct 20, 2022
@whoan whoan mentioned this issue Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whoan whoan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use yaml parser to allow comments and improve code overall whoan/docker-build-with-cache-action
1 participant
@whoan