emitter.AssignPathContext not thread-safe

[thisisaaronland]

More specifically context.WithValue does not return a new context but rather "returns a copy of parent" which means that it's possible for the path (associated with a context) will get changed before the filehandle associated with it has been processed.

For example:

2021/10/01 23:52:48 WTF /usr/local/data/sfomuseum-data-flights-2021-09/data/174/635/409/7/1746354097-alt-swim-path.geojson
2021/10/01 23:52:48 WTF 2 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/635/409/7/1746354097-alt-swim-path.geojson
2021/10/01 23:52:48 WTF /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 WTF 2 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 WTF /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 WTF 2 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 WTF 3 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 WTF 4 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 WTF 3 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 time to index paths (1) 10.384281109s
2021/10/01 23:52:48 WTF 4 /usr/local/data/sfomuseum-data-flights-2021-09/data/174/636/001/1/1746360011.geojson
2021/10/01 23:52:48 Failed crawl callback for /usr/local/data/sfomuseum-data-flights-2021-09/data/174/635/409/7/1746354097-alt-swim-route.geojson: /usr/local/data/sfomuseum-data-fligh\
ts-2021-09/data/174/636/001/1/1746360011.geojson is missing flysfo:date

[thisisaaronland]

There is no "fixing" this short of changing the underlying interfaces so now there is a v2 release.

https://github.com/whosonfirst/go-whosonfirst-iterate/releases/tag/v2.0.0