Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose of improvement of the translation addition workflow #194

Closed
Lakshamana opened this issue Jun 30, 2019 · 1 comment
Closed

Propose of improvement of the translation addition workflow #194

Lakshamana opened this issue Jun 30, 2019 · 1 comment
Labels
2.0.0 Priority for v2.0.0 release enhancement Improves existing features performance Makes things go zoom!

Comments

@Lakshamana
Copy link
Contributor

Lakshamana commented Jun 30, 2019 •
edited
Loading

Although it is easy to add new translations (because of translate.sh), the process of adding new translations is still manual (manual edition in some files) and then it could lead to mistakes in the time to add new languages. In order to minimize those mistakes and turn contributors more confident to this process, I propose here an automatic way:
Just run (for instance):
./translate.sh Deutsch de
and then it's done.
I was working on it and will submit a PR.
@Lakshamana Lakshamana mentioned this issue Jun 30, 2019
Merged
@whyboris whyboris added 2.0.0 Priority for v2.0.0 release enhancement Improves existing features performance Makes things go zoom! labels Jul 4, 2019
@whyboris
Copy link
Owner

Thank you again for your work @Lakshamana 🙇

Closed with #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0.0 Priority for v2.0.0 release enhancement Improves existing features performance Makes things go zoom!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whyboris @Lakshamana