Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Package structure #193

Open
schomatis opened this issue Aug 7, 2018 · 3 comments
Open

Extend the Package structure #193

schomatis opened this issue Aug 7, 2018 · 3 comments
Assignees

Comments

@schomatis
Copy link
Collaborator

To not only contain the package.json information (how to call that? package definition?) but also other working details, like the package directory, that conceptually are very close to the package definition. The question is whether to rename it or extend it in a separate structure.

@schomatis schomatis self-assigned this Aug 7, 2018
@Stebalien
Copy link
Collaborator

FYI: #145 (comment)

However, I definitely would not include "working details" like the package directory.


You should also check out #179 (comment)

The plan (at least the last time I discussed this with Why) was to make gx into a lock file manager and rely on language specific package managers for everything else. This'll give us what we want (dependable package "vendoring" without duplication) without antagonizing the rest of the go world.

@schomatis
Copy link
Collaborator Author

Thanks for the references.

Just to clarify, I don't mean including the directory inside the package.json, but some functions I'm seeing in the code carry the Package structure and alongside the string with the path where it's installing it. I wanted to consolidate those two in a coherent structure (that may or may not be Package). That is, I simply plan to restructure some internal parts of the gx/gx-go repos, but most definitely not change API or how it's designed (that's something that should be discussed in the issues you're pointing to).

@Stebalien
Copy link
Collaborator

Ah. I see. Yes, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants