-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for a ZooKeeper Master Detector #1
Comments
Implemented at a835b12. |
Just giving this a go now on a staging cluster, actually. I'll close it if it seems to work fine. |
In general it seems to work OK (the zookeeper group aspect) but I think my tested around ZK also falls down with #15. In the event of an identical appointment, presumably the code that continues to re-connect to the known master should kick in? I think that bit is broken.
|
thanks for the report. I'll take a closer look. |
Simply removing the check from here seems to do the trick, but I don't think that's the real solution. Edit: I also added the following method to the scheduler; def exited(self, pid):
if pid == self.master:
log.info('Disconnected from current master: %s' % pid)
self.context.delay(self.MASTER_DETECTION_RETRY_SECONDS, self.pid, 'detect') |
Just getting to grips with things, but I assume it's just a case of implementing one of those in
pesos.detector
?The text was updated successfully, but these errors were encountered: