Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Tests check is failing on CI #413

Closed
jtpio opened this issue Jul 27, 2022 · 3 comments
Closed

UI Tests check is failing on CI #413

jtpio opened this issue Jul 27, 2022 · 3 comments

Comments

@jtpio
Copy link
Contributor

jtpio commented Jul 27, 2022

Opening a new issue since the check is failing on the latest commit on master: 1c08f9f

image

Opening the report shows some differences with the UI elements:

image

Not sure if this was introduced in a previous PR, but probably updating the reference snapshots should help fix it.
@jtpio jtpio mentioned this issue Jul 27, 2022
Merged
@jtpio
Copy link
Contributor Author

jtpio commented Jul 27, 2022 •
edited
Loading

Also the UI Tests setup could be updated to use a more recent @jupyterlab/galata based on Playwright: https://github.com/jupyterlab/jupyterlab/tree/master/galata

For example:

@jtpio
Copy link
Contributor Author

jtpio commented Jul 27, 2022

Upgrading to the newer setup would also allow for integrations like automated snapshots updates with a bot: https://github.com/jupyterlab/maintainer-tools#update-snapshots

@maartenbreddels
Copy link
Collaborator

Partially fixed in #424
(not yet upgraded, will keep that in mind!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtpio @maartenbreddels