Embeding working with performance == 1 or 2

[jeammimi]

No description provided.

[maartenbreddels]

Nice that it's working, could you make sure that the previous value is set by putting it in a try/finally block:

try:
  ....
finally:
  pass # this code will execute whatever happens

[maartenbreddels]

👍

[coveralls]

Coverage increased (+0.08%) to 79.441% when pulling 722ff51 on jeammimi:Embeding2 into e3fbe36 on maartenbreddels:master.

[coveralls]

Coverage increased (+1.2%) to 80.586% when pulling f60eed9 on jeammimi:Embeding2 into e3fbe36 on maartenbreddels:master.

[maartenbreddels]

merged, thanks again!

[jeammimi]

You are wellcome! Now you can set performance == 1 by default :)

[maartenbreddels]

I think that is true actually!
Also, the performance = 2 case will be supported for the next release of ipywidgets, jupyter-widgets/ipywidgets#1194 got merged. So then we can have sequences with non-constant length arrays. Not sure what we need to do with performance == 2, then, maybe just remove the performance stuff, and by default try to send it as binary.