Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a short timeout to _check_version() requests call #853

Open
ntjess opened this issue Nov 7, 2024 · 1 comment · May be fixed by #855
Open

Add a short timeout to _check_version() requests call #853

ntjess opened this issue Nov 7, 2024 · 1 comment · May be fixed by #855

Comments

@ntjess
Copy link
Contributor

ntjess commented Nov 7, 2024

Some corporate proxies deny access to pypi.org. In these cases, solara run app.py hangs while it tries to make contact with pypi to check whether its version is up-to-date. Ideally, the call to requests.get() occurs with timeout=1 or something very short & reasonable to prevent inordinate app load times, without requiring an explicit --no-check-version (which is unintuitive without debugging)
@maartenbreddels
Copy link
Contributor

I agree, that can be very annoying. I think it can be even shorter, max 200ms, because it's fine is we miss it. Do you plan to open a PR for that, or would you rather have us look at it?

@ntjess ntjess linked a pull request Nov 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add timeout to pypi version request, preventing undue hangups on startup ntjess/solara
2 participants
@maartenbreddels @ntjess