feat: add mhchem katex extension #678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhchem package provides commands for typesetting chemical molecular formulae and equations
maartenbreddels
requested changes
Jul 3, 2024
solara/components/markdown.py
Outdated
| @@ -157,6 +158,11 @@ def _markdown_template( | |||
| async loadMermaid() { | |||
| return (await this.import([`${this.getCdn()}/mermaid@10.8.0/dist/mermaid.min.js`]))[0] | |||
| }, | |||
| async loadMHchem() { | |||
| await this.loadKatex(); | |||
There was a problem hiding this comment.
Suggested change
| await this.loadKatex(); | |
| await this.loadKatex(); |
Suggested change
| await this.loadKatex(); |
This will cause the CSS to be added twice,
solara/components/markdown.py
Outdated
| @@ -92,6 +92,7 @@ def _markdown_template( | |||
| await this.loadRequire(); | |||
| this.mermaid = await this.loadMermaid(); | |||
| this.mermaid.init(); | |||
| await this.loadMHchem(); | |||
There was a problem hiding this comment.
I guess we need to move that to after line 110, if/when we use katex.
|
I've now added the loading of mhchem to the same |
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
86646f5
to
df2fd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mhchem package provides commands for typesetting chemical molecular formulae and equations
mhchem katex extension docs are here
this contribution is a combination of copy-paste with suggestions from codeium
example:
output:
