Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat-deploy-ethers causes unexpected warnings. #400

Closed
neulad opened this issue Dec 17, 2022 · 1 comment
Closed

hardhat-deploy-ethers causes unexpected warnings. #400

neulad opened this issue Dec 17, 2022 · 1 comment

Comments

@neulad
Copy link

neulad commented Dec 17, 2022

Describe the bug
With the current version of hardhat (2.12.4) hardhat-ethers is loaded from hardhat-toolbox package. So as the best way to replace default hardhat-ethers package with npm:hardhat-deploy-ethers I used custom overrides in package.json file, which you can see below

  "overrides": {
    "@nomicfoundation/hardhat-toolbox": {
      "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers"
    }
  }

It worked perfectly well, however it stopped working few days ago and started to throw this error instead:


image


I decided to just install hardhat-deploy-ethers using npm install --save-dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers command. This trick worked, however I get huge bunch of warnings that leaves me in concern


image


The whole idea of adding overrides to package.json was to avoid this kind of errors and build more clear peer dependencies.

What is the solution for this issue, with comparator, or maybe I mayble I install hardhat-deploy-ethers in the wrong way?

To Reproduce
Steps to reproduce the behavior:

  1. execute npm install --save-dev @nomiclabs/hardhat-ethers@npm:hardhat-deploy-ethers
  2. See error

versions

  • hardhat-deploy 0.11.22
  • hardhat 2.12.4
  • nodejs 16.18.0
  • npm 9.2.0
@neulad
Copy link
Author

neulad commented Dec 20, 2022

If anybody gets this error, it's because 9.2.0 version of npm doesn't accept npm:hardhat-deploy-ethers. Downgrade it to 8.9.0 and it will work. Reference: npm/cli#5955

@neulad neulad closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant