Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to mark the important
.wups
sections with the "used" attribute. This ensures that even aggressive optimisations (e.g. LTO) will not remove the hooks and WUPS metadata.Since the used attribute needs to be on the variable itself (not an
extern
), move all attributes to the used attribute.extern
in C++ also implies C linkage, so specify C linkage.With that groundwork in place, enable an LTO build. This isn't super important - the
used
attributes are needed for plugins to use LTO - but it's basically free to enable it for the library too, so why not?