Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links for IP editors in userspace logs #316

Open
TechnoSquirrel69 opened this issue Jan 1, 2024 · 2 comments
Open

Broken links for IP editors in userspace logs #316

TechnoSquirrel69 opened this issue Jan 1, 2024 · 2 comments
Labels
C-bug Category: bug

Comments

@TechnoSquirrel69
Copy link

Example diff.

Userspace log entries incorrectly create links to the "user pages" of IP addresses ([[User:192.168.1.1]]), instead of, say, the contributions page. An easy fix might be to emulate Twinkle and use {{User}}, which has all the relevant links.

@primefac
Copy link

primefac commented Jan 1, 2024

Just noting for the sake of pedantry that this isn't necessarily "incorrect", just not the most helpful/useful link to provide as IPs do not have user pages.

That being said, I would probably make the argument that linking to all editors' contributions (IP or editor) would be more useful than linking to their (often redlinked) user page.

@TechnoSquirrel69
Copy link
Author

I think I would agree with that comment, which is why I suggested the {{User}} template — that'd be getting two birds with one stone, and would bypass the need to create a check for whether the submitter is an IP or not.

@NovemLinguae NovemLinguae added the C-bug Category: bug label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants