Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up mah and making attributetype printable #849

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mtao
Copy link
Collaborator

@mtao mtao commented Dec 13, 2024

Making it so AttributeType is printable and cleaning up some debug in MeshAttribtueHAndle

Also adding a cmake option to enable/disable component unit tests (disabling components turns out to be useful when internet is flaky due to use of wmtk_data repo).

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.16%. Comparing base (bd2e000) to head (01aa6a1).

Files with missing lines Patch % Lines
src/wmtk/attribute/AttributeType.cpp 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   77.16%   77.16%   -0.01%     
==========================================
  Files         480      481       +1     
  Lines       23759    23772      +13     
  Branches     2656     2656              
==========================================
+ Hits        18333    18343      +10     
- Misses       5415     5418       +3     
  Partials       11       11              
Flag Coverage Δ
wildmeshing 77.16% <78.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant