Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

HTML comments in ad-code #22

Open
ppc1337 opened this issue May 18, 2016 · 5 comments
Open

HTML comments in ad-code #22

ppc1337 opened this issue May 18, 2016 · 5 comments

Comments

@ppc1337
Copy link

ppc1337 commented May 18, 2016

Hey guys,

I'm using lazy-ads on wihel.de and in the whole I'm very happy with it. But i noticed that some html-comments from the advertisers are displayd within the delivery with lazy-ads. I asked them if they can prevent this behaviour and they told me, that they put these comments in the way it should be, e.g.

They told me also that it looks like lazy-ads removes the "!" from these comments and then these comments are presented on my site. Is there any setting or magic I can do so the html-comments from the advertisers will work as expceted and are not changed (so they are not appearing on the site)?

@emilv
Copy link

emilv commented May 25, 2016

See #19 and a proposed fix in #20.

@ppc1337
Copy link
Author

ppc1337 commented May 25, 2016

Hey Emil,

thanks for your hint. Because I'm not a developer I have some difficulties with the new implementation. This is my code for now:

<div class="ad" data-lazyad data-matchmedia="only screen and (min-width: 1023px)" style="max-width:970px;margin:0 auto;max-height:300px;margin-bottom:-1px;text-align:center;" class="is_ipad_desktop">
    <script type="text/lazyad">
      <!--lazy
        <script type="text/javascript" language="javascript" src="https://www2.glam.com/app/site/affiliate/viewChannelModule.act?mName=viewAdJs&affiliateId=1659609295&adSize=970x66"></script>
      lazy-->
    </script>
  </div>

How is the right transformation with your hint?

Thanks in advance,
Martin

@ppc1337
Copy link
Author

ppc1337 commented May 30, 2016

Sorry the code wasn't visible. Fixed it in my comment right now

@ppc1337
Copy link
Author

ppc1337 commented Jun 11, 2016

no idea?

@OpenSourceInc
Copy link

OpenSourceInc commented Feb 24, 2021

Code must be like the following.

<div class="ad" data-lazyad data-matchmedia="only screen and (min-width: 1023px)" style="max-width:970px;margin:0 auto;max-height:300px;margin-bottom:-1px;text-align:center;" class="is_ipad_desktop">
    <script type="text/lazyad">
      <!--
        <script type="text/javascript" language="javascript" src="https://www2.glam.com/app/site/affiliate/viewChannelModule.act?mName=viewAdJs&affiliateId=1659609295&adSize=970x66"></script>
      -->
    </script>
  </div>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants