Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to support Swift6? #86

Closed
FledgeXu opened this issue Aug 23, 2024 · 4 comments · Fixed by #88
Closed

Any plan to support Swift6? #86

FledgeXu opened this issue Aug 23, 2024 · 4 comments · Fixed by #88
Assignees

Comments

@FledgeXu
Copy link

No description provided.

@will-lumley will-lumley self-assigned this Sep 24, 2024
@will-lumley will-lumley linked a pull request Sep 24, 2024 that will close this issue
@will-lumley
Copy link
Owner

Swift 6 is now supported. The version 5.1.0 will be the Swift 6 implementation - and will be released in a few hours.
Let me know if you need any assistance :)

@mergesort
Copy link
Contributor

@will-lumley Would you mind supporting both Swift 5 and Swift 6 at the same time, by vendoring multiple Package.swift flies like this?

My project is not yet compatible with Swift 6, so the dependency cannot be resolved on systems still using Swift 5.

Computing version for https://github.com/will-lumley/FaviconFinder
error: Dependencies could not be resolved because 'faviconfinder' >= 5.1.0 contains incompatible tools version (6.0.0) and root depends on 'faviconfinder' 5.1.1..<6.0.0.

@mergesort
Copy link
Contributor

I went ahead and made a change on a branch which should work, if you need an example or want me to create a pull request.

@will-lumley
Copy link
Owner

@mergesort Amazing, thank you for this. I'll create the PR now and push this through once CI has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants