-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't use vim.g.python3_host_prog as a candidate for python #1606
Conversation
(technically not a feature but not big enough to warrant a new major version, so this is the only way to get it to show up in the changelog via release-please) |
This is inconsistent with how other system dependencies are resolved and is not documented anywhere.
b69c81f
to
9a161c8
Compare
Hi, I think this might actually be a breaking change. On macOS, you currently have the system-python on 3.9, and homebrew python on 3.12. Even though homebrew's folders by default are in PATH before system folders, the issue is that the most recent binary is actually Using I am not sure how many other uses were – knowingly or not – relying on I think an option in the mason config to manually set which python to use might be a solution. Also, due to potentially breacking packages, this PR should be marked as breaking change (to make it show up as such in lazy.nvim etc.) |
Yeah this technically is a breaking change for sure, but I figured it was small/insignificant enough to allow it to go through in a minor bump. The rationale being that it'd simply fallback to the I completely forgot about the problems with python versioning that you mention though.. I wonder if we can follow this up by adding more versioned python candidates to attempt (i.e. I generally lean towards designing things in such a manner that it works out of the box for the vast majority, I'd like to avoid adding new settings as much as it's possible (but still leave room for it when it's needed). |
That's a good idea, yeah. I generally am also in favor of having as few settings as possible, but I feel like the mess that is Python versions probably makes a setting necessary to provide sufficient flexibility |
@chrisgrieser 👋 Would you mind trying out |
This has broken python packages for me on NixOS. I used this to only enable python3 for neovim & not install it system-wide. It sets vim.g.python3_host_prog, which was being used till now. Would appreciate if this support could be restored. |
FYI, I don't have NodeJS or Ruby installed either, but they show up in |
This has broken python for me as well on Windows using python 3.12 and using pyenv-win to manage my python versions. I also need to use vim.g.python3_host_prog = "C:\\Users\\USERNAME\\.pyenv\\pyenv-win\\versions\\3.12.2\\python.exe" And even though my env path is set fine and my terminal accesses this version of python fine using any of python, python3, or python3.12, without setting the python_3_host_prog I get several different weird behaviors in neovim 🤷♂️ |
This caught me also I'm on So far my workaround is using |
I take this back, forcing python3 to 3.11 using |
Python version compatibility is always the bane of everyone's existence 🤣🤦🏻♂️ |
@zer09 Does openSUSE not install the "canonical" |
* origin/main: tests: remove old spec (williamboman#1634) chore(main): release 1.10.0 (williamboman#1605) fix(pypi): fix variable shadowing (williamboman#1610) feat(pypi): attempt more python3 candidates (williamboman#1608) fix(golang): fix fetching package versions for packages containing subpath specifier (williamboman#1607) feat: don't use vim.g.python3_host_prog as a candidate for python (williamboman#1606) fix(ui): don't indent empty lines (williamboman#1597)
This has broken things for me as well. RHEL8's system Python is still on 3.6 which will fail to install the latest version of most Python-based LSP (it's not a problem that mason cannot find |
This is causing issues for me as well, is there a simple option to just use |
This is inconsistent with how other system dependencies are resolved and is not
documented anywhere.