Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 28-based Testing Release - report of compatibility #2

Open
ask2018 opened this issue Sep 24, 2023 · 21 comments
Open

Electron 28-based Testing Release - report of compatibility #2

ask2018 opened this issue Sep 24, 2023 · 21 comments

Comments

@ask2018
Copy link

ask2018 commented Sep 24, 2023

Hello,
thank you very much for first testing release. I'm opening this issue to report here what is working fine and what not.
I've tested 2 electron based applications on Windows 7 x64 SP1 with all updates ESU included

  1. ElectronMail https://github.com/vladimiry/ElectronMail/ - tested version 5.2.0
    This seems to be working fine. Or at least I didn't find issues yet.

  2. Tutanota Desktop https://github.com/tutao/tutanota - tested version 3.118.8
    Application just opens and exits with no error or warning.

@win32ss
Copy link
Owner

win32ss commented Sep 24, 2023

Tutanota is launching for me on Vista, 7 and 10 1809. Did you make sure that the resources folder was cleaned out before copying in Tutanota's files?

Or you can keep only default_app.asar (it's needed to direct Electron to other paths for finding applications) in resources and launch Tutanota from elsewhere by the command line (type electron X:\resources\app.asar where resources is Tutanota's resources folder).

In fact, I will make an Electron app manager to prevent these conflicts and allow a user to launch multiple applications easily.

@win32ss
Copy link
Owner

win32ss commented Sep 24, 2023

I will also report that GitHub Desktop works:
image

However, Supermium Electron on Vista only launches from the command line or it loops. This issue does not affect 7 and above so I decided to release it.

@ask2018
Copy link
Author

ask2018 commented Sep 24, 2023

Yes I've cleaned that folder. But I have found already what is causing that crash for Tutanota for me.
I cleaned my C:\Users\USERNAME\AppData\Roaming\tutanota-desktop folder and tried to run it again.
Now there was no crash. I've tried to login to my account and that is working as well.
But If I try to tick "save my login details" and try to login it crashes. Same if the login details are already saved from previous version. Crash must be related somehow to this and you need tutanota account for testing it.

@win32ss
Copy link
Owner

win32ss commented Sep 24, 2023

The crash is in the better-sqlite3 node module. It happens regardless of OS, so presumably it is related to something missing from Supermium Electron. I also tried Tutanota with VS Code 1.83 Insider's Electron executable and the same thing happens.

@ask2018
Copy link
Author

ask2018 commented Sep 24, 2023

I've tried older versions of Tutanota and last version without this crash seems to be 3.114.1 (but I'm getting there some errors on start and close).
With 3.115.2 I have already the same crash as with 3.118.8.

@MVoloshin
Copy link

image

ArmCord 3.2.4 (latest version of Discord fork). Didn't notice any glitches yet

@ask2018
Copy link
Author

ask2018 commented Sep 24, 2023

I'm facing similar crash issue as with Tutanota with Session. It is also using better-sqlite3 node module, so it might be the same reason of the crash. I can run it, but right after I input my password, it crashes.
https://github.com/oxen-io/session-desktop
Tested version 1.11.3

@win32ss
Copy link
Owner

win32ss commented Sep 24, 2023

I tried using the version of better-sqlite3 that is in Tutanota 3.114.1 with 3.118.8 and there was no change. I will build better-sqlite3 from source to get debugging symbols and try to get a clearer idea of what is happening.

@MiraakThuri
Copy link

MiraakThuri commented Sep 30, 2023

Windows 7 X64 SP1
Not working on Discord official client (last version):
Capture2

Also tried to use OpenAsar (https://github.com/GooseMod/OpenAsar) (superlight opensource replacement for Discord app.asar)
but i will get this error:
Capture

I know other clients like ArmCord exists but since they are based on the Web version they lacks alot of the features im using such as custom keybinds and exclusive fullscreen game screensharing

PS: Make no difference if i start discord using the commandline to start the App.asar from the source folder

@sergeevabc
Copy link

Anyone care to provide pre-built .zip to download and replace incompatible Electron-based app files? I'd like to test it with Obsidian (another popular Electron-based app).

@ask2018
Copy link
Author

ask2018 commented Dec 4, 2023

@sergeevabc for now you can grab precompiled testing build here: https://github.com/win32ss/supermium-electron/releases/tag/v28-testing and I guess @win32ss will provide stable build when it will be ready for more testing.

@sergeevabc
Copy link

@ask2018, alright, reporting back.
Tested x64 with Obsidian, does not work, dark empty screen.

@KandiPanda
Copy link

KandiPanda commented Dec 21, 2023

Tested the precompile build with https://github.com/FreeTubeApp/FreeTube, and 64-bit Supermium-Electron does work with nightly build freetube-0.19.1-nightly-3736 onwards (at least as of current latest build as of this writing).

Edit: Current release (Release v0.20.0 Beta) works in 64-bit Supermium-Electron, have not tested in 32-bit but would guess that it should work there as well.

Edit: Tested the current latest build (freetube-0.20.0-nightly-4263) in both 64-bit and 32-bit Supermium-Electron, seems to work fine in either.

Edit: freetube-0.21.3-nightly-4681 is still working in 64-bit Supermium-Electron, haven't checked with 32-bit in a while but would think that it would work there also.

@malisipi
Copy link

malisipi commented Feb 17, 2024

NewFlow is currently working fine in Windows 7 with Supermium Electron.

win7

@Jevil7452
Copy link

Beeper (http://beeper.com/) works fine
image

@Jevil7452
Copy link

Vencord Desktop/Vesktop (https://github.com/Vencord/Vesktop) works fine
image

@Kazcade
Copy link

Kazcade commented Jul 10, 2024

@KandiPanda

Tested the precompile build with https://github.com/FreeTubeApp/FreeTube, and 64-bit Supermium-Electron does work with nightly build freetube-0.19.1-nightly-3736 onwards (at least as of current latest build as of this writing).

Edit: Current release (Release v0.20.0 Beta) works in 64-bit Supermium-Electron, have not tested in 32-bit but would guess that it should work there as well.

Edit: Tested the current latest build (freetube-0.20.0-nightly-4263) in both 64-bit and 32-bit Supermium-Electron, seems to work fine in either.

No idea if this is still relevant, given the lack of updates, but trying this with the latest version of Freetube (v0.21.0 Beta) I am running into issue when opening additional windows inside the app - doing so results in the prior windows going blank and becoming unresponsive:

Untitled

Opening the dev console prior to this outputs the following info:

Untitled2

Reloading the window usually results in the other window blanking out, but occasionally results in both windows working, at least until any other action is taken.

I don't know if this due to an inherent limitation of Supermium or a compatibility issue with freetube. Can anybody replicate this issue? At least for me this greatly impacts usability and any fix for this would be welcome.

ADDENDUM:

This seems to be related to the number of subscribed channels, but i have no idea why. The bug does not occur (or extremely rarely, I was not able to recreate it) with a newly created profile and no saved channels/subscriptions, but after a certain number of channels have been added electron will occasionally throw the above "blank window" bug after a new channel is added - even when no other actions is taken beside pressing the "subscribe" button (i.e. no video is played). This starts to get more frequent when the list hits 40-50 channels and at about 100 channels (my current list is ~106 channels) this happens once for every 8-10 channels that are newly added. This can also be triggered by repeatedly re-subscribing to a single channel.

As the list gets larger, the number of concurrent windows that can be opened before the bug occurs gets increasingly smaller - for ~50 subscribed channels the number of usable windows is around 10, while at ~100 channels it's about 2-3 - at that point opening a new window blanks the oldest existing window.

According to ProcExplorer the process that crashes/terminates is the electron renderer (electron.exe --type=renderer...), not the utility or gpu process.

Any help in troubleshooting this would be appreciated.

@KandiPanda
Copy link

@Kazcade

Haven't had that issue myself, and I'm at 70 channels currently, though I only occasionally open multiple simultaneous windows.

How are you opening the new windows? Center-clicking something in the current one, as I do? (Also tried the "new window" button at the top out of curiosity and didn't seem to have an issue with it.)
And are you combining Supermium-Electron and FreeTube the way I am, by deleting the placeholder resources folder from Supermium-Electron and copying over the one from the FreeTube zip file?

Other visible difference I see is that I have Settings > Distractions > Side Bar > Hide Active Subscriptions enabled, may see if that helps any? (Also less importantly, I have Settings > Theme Settings > Expand Side Bar by Default and Settings > Theme Settings > Hide Side Bar Labels both disabled.)

(Just in case it's relevant, current specs are i7-940 CPU, GTX 1070 SC, 3x4GB RAM, and Windows 7 Ultimate using the Windows Classic theme.)

Also as a side note, you'll want to upgrade to v0.21.1 Beta, it has some upstream fixes in it for a couple major issues that recently developed from changes on YouTube's side:

Summary

  • This release fixes the recent major issue of videos unable to play when using the Local API.

Fixes

@Kazcade
Copy link

Kazcade commented Jul 11, 2024

@KandiPanda

Thanks for the heads-up, I had already upgraded to 0.21.1 on my other devices and did so on my desktop this morning, unfortunately it didn't change in regards to the bug.

How are you opening the new windows? Center-clicking something in the current one, as I do?

That or left-clicking on the "open new window" button next to the search bar. Doesn't make a difference, even the "new window" from the title bar ("Alt") triggers the bug.

Other visible difference I see is that I have Settings > Distractions > Side Bar > Hide Active Subscriptions enabled, may see if that helps any?

It looks like it is indeed the subscription sidebar itself that is causing the buggy behaviour, as enabling "Hide Active Subscriptions" appears to fix the issue - I was unable to trigger the bug even when opening 20+ windows during testing. Thanks for pointing that out.

In contrast to that, loading the "Channels" window multiple times (and opening videos in parallel) doesn't cause any issues. Weird.

A bit unfortunate being unable to utilize the sidebar, but usable. Still, I'd be interested as to why the sidebar (and loading the list of subscriptions in particular) leads to the instance crashing. Is there any way to enable logging for electron? The crash does not appear in the console output from what I can tell, the window simply outputs that the devtools were disconnected (as per my prior post).

@Jevil7452
Copy link

image
It doesn't work with ArmCord 3.3.0
image
ArmCord 3.2.8 works fine

@KandiPanda
Copy link

KandiPanda commented Sep 2, 2024

Ran into an issue with freetube-0.21.3-nightly-4694 in Supermium-Electron, which persists in 4698 (currently the latest nightly).

Using Alt-Left or Alt-Right (or Back/Forward in the View dropdown menu, see attached image) to go forward/back throws an error (see attached image) and do not go forward/back. (the error can be closed and FreeTube will otherwise continue to function).
image
image

The left/right arrows near the top of the window (see attached image) and using history.back() and history.forward() in the console both still work fine. (Edit: The forward/back buttons on the side of the mouse also still work fine.)
image

It appears that the PR causing the issue is FreeTubeApp/FreeTube#5626 ("Switch to non-deprecated Electron navigation history APIs") which replaces webContents#goForward() and webContents#goBack() with webContents#navigationHistory#goForward() and webContents#navigationHistory#goForward() in one place each.

(Side note, is there any chance of there being some way that I can shim Supermium-Electron for this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants