Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom id #24

Open
ullalaaron opened this issue Jul 29, 2019 · 1 comment
Open

Allow passing custom id #24

ullalaaron opened this issue Jul 29, 2019 · 1 comment

Comments

@ullalaaron
Copy link

Is it possible to pass a custom id to the tab to be opened?
Looking at the source code it looks like the id is always generated from scratch...I would like to submit a PR in order to allow the parent to specify a tabId through the config object. What do you think?

@softvar
Copy link
Member

softvar commented Jul 31, 2019

Hi @ullalaaron
No, it is not possible to provide a custom id. Though you can provide a custom name to the opened window by setting window.name or window.windowName. Check this code - https://github.com/wingify/across-tabs/blob/master/src/tab.js#L34

If there's something which can not be done via setting different name, I'll be happy to have custom id support via config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants