-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also block "Do not merge" PRs #26
Comments
Hey Paul, thanks for opening the issue :) How do you use "Do not merge"? Does it mean that the PR is still work in progress or are there other reasons why you would use that string? |
@gr2m It can mean both, often it's because there's work in progress but sometimes because a PR on another repo is blocking the current one (ie WIP on another repo). |
okay, thanks. Would this change make it work for you? - const isWip = /\bwip\b/i.test(title)
+ const isWip = /\b(wip|do not merge)\b/i.test(title) I am trying hard to keep the complexity very low as many folks including myself use the wip-bot as a showcase & tempate for own probot apps. I that change will do, I’d be happy to accept a pull request :) |
In my organisation (alphagov), we regularly mark PRs as "Do not merge" or "[DO NOT MERGE]". Does it make sense to add this to the wip-bot?
An example:
alphagov/government-frontend#700
These are strings we often exclude:
https://github.com/binaryberry/seal/blob/435fe229733a4c0b872b6f309475451479dfcedd/config/alphagov.yml#L16-L21
I'm guessing it's just a case of updating this line:
https://github.com/gr2m/wip-bot/blob/master/lib/handle-pull-request-change.js#L5
The text was updated successfully, but these errors were encountered: