Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the bot to look for a [hold] flag #68

Closed
jbialy opened this issue May 7, 2018 · 5 comments
Closed

Extend the bot to look for a [hold] flag #68

jbialy opened this issue May 7, 2018 · 5 comments

Comments

@jbialy
Copy link

jbialy commented May 7, 2018

At my work we make use of WIP and also the HOLD tag. I'm thinking of extending wip-bot to also filter if it detects HOLD in the PR title. Is this something that would be welcome?

@gr2m
Copy link
Collaborator

gr2m commented May 7, 2018

I’d fear that the word "hold" by itself might be too common and cause false positives. But as mention at #56 (comment) I’m thinking of support configuration which would allow you to customize the terms as well as the places where the bot looks for it. Would that work for you?

@jbialy
Copy link
Author

jbialy commented May 7, 2018

That sounds like a good idea! I think having configurable terms which the bot would search for makes a lot of sense. I was also going to add that it'd be nice to have the bot find "work in progress" terms in both the PR title and description when it appears as [WIP]. I could be wrong, but I don't think that it currently detects a WIP text if it's placed inside square brackets but I haven't fully tested it!

@gr2m
Copy link
Collaborator

gr2m commented May 8, 2018

I don't think that it currently detects a WIP text if it's placed inside square brackets

I’m pretty sure it should work with square brackets

@jbialy jbialy changed the title Extend the bot to look for a hold flag Extend the bot to look for a [hold] flag May 9, 2018
@u2606
Copy link

u2606 commented Jun 1, 2018

Configurability would be great! In particular, my team often uses a “hold” label on GitHub to indicate that a PR shouldn’t be merged yet. Giving the bot the ability to search labels, too, would dovetail nicely with allowing configuration.

@gr2m
Copy link
Collaborator

gr2m commented Jun 15, 2018

closing in favor of #96 :) Would love your input there!

@gr2m gr2m closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants