-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the bot to look for a [hold] flag #68
Comments
I’d fear that the word "hold" by itself might be too common and cause false positives. But as mention at #56 (comment) I’m thinking of support configuration which would allow you to customize the terms as well as the places where the bot looks for it. Would that work for you? |
That sounds like a good idea! I think having configurable terms which the bot would search for makes a lot of sense. I was also going to add that it'd be nice to have the bot find "work in progress" terms in both the PR title and description when it appears as [WIP]. I could be wrong, but I don't think that it currently detects a WIP text if it's placed inside square brackets but I haven't fully tested it! |
I’m pretty sure it should work with square brackets |
Configurability would be great! In particular, my team often uses a “hold” label on GitHub to indicate that a PR shouldn’t be merged yet. Giving the bot the ability to search labels, too, would dovetail nicely with allowing configuration. |
closing in favor of #96 :) Would love your input there! |
At my work we make use of WIP and also the HOLD tag. I'm thinking of extending wip-bot to also filter if it detects HOLD in the PR title. Is this something that would be welcome?
The text was updated successfully, but these errors were encountered: