Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Upgrade pattern improvements #344

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

thermiteplasma
Copy link
Contributor

PR to match when variables are passed as the component name and also handle multi line arguments. Also added the missing $this->dispatch|$this->emit methods called from a PHP class

It should handle a period or hyphen in the component name and supports many argument formatting types

Below are some test regex examples

  1. Using $dispatch: https://regexr.com/7iajb
  2. Using $this->dispatch: https://regexr.com/7iafs
  3. Using Livewire.dispatch: https://regexr.com/7iaje

@PhiloNL PhiloNL merged commit beee4d2 into wire-elements:main Aug 16, 2023
1 check passed
@PhiloNL
Copy link
Contributor

PhiloNL commented Aug 16, 2023

Awesome! Thanks! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants