feat: terminate the SFT 1:1 call once the other person hangup the call - WPB-7152 #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaterinaWire
changed the title
Test Results5 313 tests 5 313 ✅ 18m 15s ⏱️ Results for commit bf2fa0e. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 5313 Passed, 0 Skipped, 57.26s Total Time |
johnxnguyen
reviewed
Aug 7, 2024
David-Henner
reviewed
Aug 7, 2024
…atureRepositoryTests.swift Co-authored-by: David-Henner <david.henner@wire.com>
…e-1-1-calls-WPB-7152
Co-authored-by: John Nguyen <28632506+johnxnguyen@users.noreply.github.com>
johnxnguyen
approved these changes
Aug 8, 2024
Base automatically changed from
feat/1-1-calls-in-federated-environment
to
release/cycle-3.112
August 8, 2024 15:08
echoes-hq
bot
added
the
echoes: product-roadmap
David-Henner
approved these changes
Aug 8, 2024
zenkins
pushed a commit
that referenced
this pull request
Aug 9, 2024
…l - WPB-7152 (#1772) Co-authored-by: David-Henner <david.henner@wire.com> Co-authored-by: John Nguyen <28632506+johnxnguyen@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A follow up PR of #1742
When two participants are in a 1:1 call on SFT, if someone ends the call, the call will stay ongoing for the other person until timeout.
This is because we don't rely on the SFT list, but we have a subconversation that we use for calling.
To resolve that, we agreed on a short term approch which aims to :
Testing
Setup conferenceCalling feature flag, so useSFTForOneToOneCalls is true.
Make a 1:1 call between users from different backends.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: