Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"/" separator for flat JSON files could not be unique #767

Closed
frafra opened this issue May 30, 2022 · 7 comments
Closed

"/" separator for flat JSON files could not be unique #767

frafra opened this issue May 30, 2022 · 7 comments

Comments

@frafra
Copy link

frafra commented May 30, 2022

Hi,
I tried to use a/b as a key in a test JSON file, to see how agate would flatten it, since / is added when recursing JSON files. I see that agate keeps that original /, so the output can be misleading.
I would suggest having an option to replace the original / to avoid confusion,

@jpmckinney
Copy link
Member

At a minimum, this behavior can be documented.

@jpmckinney
Copy link
Member

I've documented it for now. I'm not sure that this sort of collision ever occurs in real data.

@frafra
Copy link
Author

frafra commented Oct 19, 2023

Thanks :) Well, it happened on my data 😄

@jpmckinney
Copy link
Member

What were the colliding keys in your data?

@frafra
Copy link
Author

frafra commented Oct 19, 2023

All of them, because the original file has two lines of header, so they were processed into a single header line containing "/" as separator. Rather uncommon, I know :)

@jpmckinney
Copy link
Member

Strange, can you paste the first few lines here?

@frafra
Copy link
Author

frafra commented Oct 23, 2023

Well, it has been a while ago and I moved forward. sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants