-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment of the connector images #418
Comments
I managed to patch the code, the results are quite satisfying for me: I have added an alignment attribute (with possible values 'under', 'above', 'left', 'right') to the images for connectors only. Questions: Code lives here in the case if someone want to peek into it: |
@martonmiklos - Thank you very much for this feature suggestion, and I encourage you to create a draft PR with your code suggestions. I have tried your code and and have some comments. If you create a draft PR, then I can place such comments directly at the relevant code changes. My preliminary comments:
|
- Rename image alignment to position - Rename under to below - Display the above positioned images right above the pins list Fixes wireviz#418
Hi @kvid Many thanks for your feedback, I almost thought that the project development stalled totally ;) Draft PR created see: #420
I am not a native English speaker and my English is not particularly good, so I changed the under to below if it makes more sense to you.
Yes I agree, fixed it.
Position is better I think too, changed it.
Uhm yes, I will fix this.
Agreed! |
I have some connectors like this:
However when positioned below the connector pin table they waste a lot of vertical space.
If they could be aligned next to the pin table the diagrams generated would be more compact:
Is there any way to such an alignment?
If no I would be glad to fix this, any recommendations on the syntax is welcome!
The text was updated successfully, but these errors were encountered: