diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml index 92ec5656d..1763a329a 100644 --- a/.github/workflows/deploy-staging.yml +++ b/.github/workflows/deploy-staging.yml @@ -71,7 +71,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 18 + node-version: 16 - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@v1 @@ -151,7 +151,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 18 + node-version: 16 - name: Create environment.prod.ts file run: node scripts/createEnvFile.js @@ -173,6 +173,7 @@ jobs: REACT_APP_FROALA_API_KEY: ${{ secrets.FROALA_API_KEY }} NODE_OPTIONS: "--openssl-legacy-provider" run: | + unset NODE_OPTIONS npm set "//registry.npmjs.org/:_authToken" ${{ secrets.NPM_TOKEN }} yarn yarn nx build ${{ matrix.editor }} diff --git a/CHANGES.md b/CHANGES.md index 65820d3d6..817faedc2 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -12,6 +12,7 @@ Last release of this project was 5th of February 2024. ### Unreleased - fix: Error when open a plain text with MT/CT editor. #KB-44250 - feat: Add version text on html-viewer window property. #KB-43186 + - fix: Error when double-click a plain text and open MT/CT editor. #KB-44249 ### 8.8.2 2024-02-05 diff --git a/packages/devkit/src/integrationmodel.js b/packages/devkit/src/integrationmodel.js index 65cb26577..0cc156b92 100644 --- a/packages/devkit/src/integrationmodel.js +++ b/packages/devkit/src/integrationmodel.js @@ -123,7 +123,7 @@ export default class IntegrationModel { /** * Specify if editor will open in hand mode only */ - this.forcedHandMode = integrationModelProperties?.integrationParameters.forcedHandMode ?? false; + this.forcedHandMode = integrationModelProperties?.integrationParameters?.forcedHandMode ?? false; /** * Indicates if an image is selected. Needed to resize the image to the original size in case diff --git a/packages/froala/wiris.src.js b/packages/froala/wiris.src.js index 2a1a6e6c7..aa0170e02 100644 --- a/packages/froala/wiris.src.js +++ b/packages/froala/wiris.src.js @@ -183,12 +183,6 @@ export class FroalaIntegration extends IntegrationModel { return; } - // Save a image to a temporal register to detect when we want to - // change between MT and CT. - // Will be deleted when inserting the formula or canceling it - // When double clicking a word, Froala assigns the whole div that contains that word to `element`. - // We only really want temporalImage to be an img element, not divs: - this.core.editionProperties.temporalImage = element.tagName.toLowerCase() === 'img' ? element : null; super.doubleClickHandler(element); } diff --git a/packages/generic/wirisplugin-generic.src.js b/packages/generic/wirisplugin-generic.src.js index 1dc30945a..125ea8e7b 100644 --- a/packages/generic/wirisplugin-generic.src.js +++ b/packages/generic/wirisplugin-generic.src.js @@ -252,15 +252,6 @@ export default class GenericIntegration extends IntegrationModel { } } - /** - * @inheritdoc - * @param {HTMLElement} element - DOM object target. - */ - doubleClickHandler(element) { - this.core.editionProperties.temporalImage = element; - super.doubleClickHandler(element); - } - /** @inheritdoc */ openNewFormulaEditor() { this.core.editionProperties.dbclick = false;