-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Incompatibility] Crash with Smooth Scrolling #18
Comments
I also oppened an issue on their issue report |
A log of the crash would help figure out exactly the incompatibility |
hi, i'm the developer of smooth scrolling i have now fixed the crash in my dev branch but most non-vanilla stuff you add is still broken (doesn't scroll smoothly and some minor unexpected issues occur)... maybe i can fix it by using matrixtransform instead of modifying the render positions of items... i think that you don't need to do anything to fix the issues |
most of the issues (if not all) will be fixed in smooth scrolling version 2.1.3 without the need to update this mod. |
i would like to fix one more issue though... so where can i get the items from your mod for any position in the tab? if i don't get them, the items will either mismatch sometimes when scrolling at the top or bottom or instantly disappear... i want to use that in my mixins/handledscreenmixin at around line 67 in my code |
Sorry for not getting back to you on this issue as I have been busy with other mods and life stuff to say the least. I have made a PR that contains fixes for the issues outlined for 3.4.0: SmajloSlovakian/Minecraft-Smooth-Scrolling#49 |
sorry you had to put up with my garbage code spaghetti and thanks for the pr... i'm now gonna try it and i may make some changes to it if i see fit... i make no promises that i will abide by the rules you just applied to the whole project by i'll try :)... thanks |
there is just one problem: it can't find io.wispforest.condensed_creative.entry.EntryContainer... it does find everything else but this one line errors out and so minecraft crashes with these two mods when i open creative inventory... i'll try to fix it myself but if you know what should be done, feel free to tell |
Hmmm odd, try refreshing gradle as it worked for me and the files should be within the latest CC version |
i'll be able to try it out again tomorrow or later... and i don't see the file on your github so idk... |
oh i think i see that you don't have it updated on github so that's why i don't see it... well then idk how it would use a lower version of your mod... gradle is weird... |
Pushed the changes to Github btw |
tried it out with version 3.4.0 in the run/mods folder... it now does this when i go to the second page of creative inventory, go down and go up... it is also a bit inconsistent on if it will render the mod's item entries or vanilla's on the end of the scrolling... ---- Minecraft Crash Report ---- Time: 2024-08-18 17:39:10 java.lang.ClassCastException: class smsk.smoothscroll.compat.CondensedInventoryCompat$CondensedEntryDelegatingInventory cannot be cast to class io.wispforest.condensed_creative.util.CondensedInventory (smsk.smoothscroll.compat.CondensedInventoryCompat$CondensedEntryDelegatingInventory and io.wispforest.condensed_creative.util.CondensedInventory are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @97e1986) A detailed walkthrough of the error, its code path and all known details is as follows:-- Head -- -- Screen render details -- -- Uptime -- -- Affected level -- -- Last reload -- -- System Details --
FAILURE: Build failed with an exception.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. For more on this, please refer to https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
|
Ah that is my bad as I messed up with not removing the direct casts for |
Pushed an update for such hopefully fixing the crash |
crashes are all fixed... but the trailing smooth scrolling items are still inconsistant - at least on the first two pages it just tends to copy one item all over the row for some reason but on other tabs it works great (aside from one small issue that the item backgrounds aren't joined and have a blue line between them - i don't expect you to fix that)... so that thing i would like you to fix properly because i don't think i'm able to do that... btw you can set the creative screen smooth scrolling speed to 0.99 in the config file of my mod and then reload resources so you can see the issue more easily |
The games crashes when you open the creative inventory with the Smooth Scrolling mod...
The text was updated successfully, but these errors were encountered: