Skip to content
This repository has been archived by the owner on Feb 10, 2025. It is now read-only.

Reproduction - Cloudflare adapter hangs process using Vitest #443

Conversation

skf-funzt
Copy link

@skf-funzt skf-funzt commented Nov 15, 2024

Changes

  • Added a reproduction package
  • Added asdf for local development

Testing

  • Added test and respective GitHub workflow to showcase haning process using vitest

Docs

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 609b92c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@skf-funzt skf-funzt changed the title test(cloudflare): adapter hangs vitest triggering close timeout Reproduction - Cloudflare adapter hangs process using Vitest Nov 15, 2024
@skf-funzt skf-funzt marked this pull request as draft November 15, 2024 08:41
@skf-funzt skf-funzt force-pushed the reproduction/vitest-hanging-process branch from d4c257b to 609b92c Compare November 15, 2024 08:48
Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking, to make sure this doesn't get merged by accident.

@ematipico
Copy link
Member

Hi, we moved the cloudflare adapter in a new repository: https://github.com/withastro/astro/tree/main/packages/integrations/cloudflare

We will achieve this repository soon, so if you wish to land this PR, you'll have to create a new one.

@ematipico ematipico closed this Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants