From 15420cef8414c16708ccf17a2f925f9e2e16d8c2 Mon Sep 17 00:00:00 2001 From: lilnasy <69170106+lilnasy@users.noreply.github.com> Date: Wed, 6 Dec 2023 13:20:18 +0000 Subject: [PATCH] proceed as usual after warning --- packages/astro/src/core/routing/manifest/create.ts | 2 +- packages/astro/test/redirects.test.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/astro/src/core/routing/manifest/create.ts b/packages/astro/src/core/routing/manifest/create.ts index 720a2deaac42b..379f458eb50f6 100644 --- a/packages/astro/src/core/routing/manifest/create.ts +++ b/packages/astro/src/core/routing/manifest/create.ts @@ -460,7 +460,7 @@ export function createRouteManifest( destination = to.destination } if (destination.startsWith("http")) { - return logger.error('redirects', `Redirecting to an external URL is not supported: ${from} -> ${to}`); + logger.warn('redirects', `Redirecting to an external URL is not officially supported: ${from} -> ${to}`); } } diff --git a/packages/astro/test/redirects.test.js b/packages/astro/test/redirects.test.js index b9417643d059d..63a09312478fb 100644 --- a/packages/astro/test/redirects.test.js +++ b/packages/astro/test/redirects.test.js @@ -28,7 +28,8 @@ describe('Astro.redirect', () => { expect(response.headers.get('location')).to.equal('/login'); }); - it('Ignores external redirect', async () => { + // ref: https://github.com/withastro/astro/pull/9287 + it.skip('Ignores external redirect', async () => { const app = await fixture.loadTestAdapterApp(); const request = new Request('http://example.com/external/redirect'); const response = await app.render(request);