Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: False 404 logged for public files when base is set #3808

Closed
1 task
AllanChain opened this issue Jul 4, 2022 · 2 comments
Closed
1 task

🐛 BUG: False 404 logged for public files when base is set #3808

AllanChain opened this issue Jul 4, 2022 · 2 comments
Labels
- P2: nice to have Not breaking anything but nice to have (priority)

Comments

@AllanChain
Copy link
Contributor

AllanChain commented Jul 4, 2022

What version of astro are you using?

1.0.0-beta.63

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Linux

Describe the Bug

When a base is configured to /blog and the page requests an image from the public/ folder via src="/blog/full-logo-light.png", although the request succeeds and the image is correctly displayed, there is a false 404 message logged in the console:

[serve]    404                /blog/full-logo-light.png

The expected behavior is that the above message is never logged.

Edit: And if a 404.astro file is added to src/pages/, the image will not load. The expected behavior is that the image will load anyway.

Link to Minimal Reproducible Example

https://github.com/AllanChain/astro-base-bug

Participation

  • I am willing to submit a pull request for this issue.
@natemoo-re
Copy link
Member

Thanks for opening an issue @AllanChain!

Since the bug is just an erroneous console.log but other behavior is working properly, I'm going to mark this as a relatively low priority for now. Hopefully we can circle back and tackle this soon, otherwise contributions are welcome!

@natemoo-re natemoo-re added s1-small - P2: nice to have Not breaking anything but nice to have (priority) labels Jul 8, 2022
@natemoo-re
Copy link
Member

Thank you! I didn't realize there was more problematic behavior here than the console.log or I would bumped the priority. Really appreciate the fix.

Going to mark this as closed since your PR was merged in #3942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority)
Projects
None yet
Development

No branches or pull requests

2 participants