Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Edge Functions route pattern validation error #4376

Closed
1 task done
jackiewmacharia opened this issue Aug 18, 2022 · 2 comments · Fixed by #4722
Closed
1 task done

Netlify Edge Functions route pattern validation error #4376

jackiewmacharia opened this issue Aug 18, 2022 · 2 comments · Fixed by #4722
Assignees
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)

Comments

@jackiewmacharia
Copy link

What version of astro are you using?

1.0.6

Are you using an SSR adapter? If so, which one?

Netlify

What package manager are you using?

npm

What operating system are you using?

Mac

Describe the Bug

We set up validation for Edge Functions manifest.json recently and came across some build failures from some astro route patterns. This happens if a route pattern is set up at this point: astro/blob/main/packages/integrations/netlify/src/integration-edge-functions.ts. This error is triggered during netlify build.

We currently handle this by serializing it in this way in netlify/build. I have minimal repro code here and fix on my fork branch here ready for a PR if that's okay. Instructions to test the fix available here.

Error screenshot:
ntl build err

Link to Minimal Reproducible Example

https://github.com/jackiewmacharia/astro-cattos

Participation

  • I am willing to submit a pull request for this issue.
@FredKSchott FredKSchott added the - P3: minor bug An edge case that only affects very specific usage (priority) label Aug 21, 2022
@matthewp matthewp assigned bholmesdev and unassigned matthewp Aug 23, 2022
@kingroho
Copy link

I'm getting this error too. Vercel and Cloudflare adapters seem to be working fine.

@bholmesdev
Copy link
Contributor

@jackiewmacharia Ah, thanks for the thorough investigation and fix! Such a joy reading issues like this 😄
I confirmed this issue exists on Netlify CLI 10.18 and later, and can also confirm your fix solves the issue. I'll make a PR for expediency here but I'll tag your profile as a co-author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants