Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@astrojs/image] image doesn't render properly in dev when no transforms props are used #4931

Closed
1 task done
tony-sull opened this issue Sep 30, 2022 · 0 comments · Fixed by #4933
Closed
1 task done
Assignees
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: image Related to the `@astrojs/image` package (scope)

Comments

@tony-sull
Copy link
Contributor

What version of astro are you using?

1.4.0

Are you using an SSR adapter? If so, which one?

non

What package manager are you using?

yarn

What operating system are you using?

mac

Describe the Bug

During astro dev, if an <Image /> component is used without any transform props (format, width, height, etc), the vite plugin's dev server ignores the request and the image 404s

Expected behavior: The vite plugin should just return the original file as-is in dev, similar to what will happen in astro build

Link to Minimal Reproducible Example

https://github.com/ChristineTham/christinetham.github.io

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) s1-small pkg: image Related to the `@astrojs/image` package (scope) labels Sep 30, 2022
@tony-sull tony-sull self-assigned this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: image Related to the `@astrojs/image` package (scope)
Projects
None yet
1 participant