Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move db ambient types to separate module #10340

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

bholmesdev
Copy link
Contributor

Changes

Mixing a declare module statement within index.d.ts does not properly declare the type. This is because index.d.ts contains an export statement already.

  • Move astro:db declaration to separate virtual.d.ts
  • Refactor barrel export to individual exports. Barrel exports from a relative path are not supported in virtual modules sadly

Testing

Docs

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: 57f0989

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bholmesdev bholmesdev merged commit a60861c into main Mar 6, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/db-ambient-ts branch March 6, 2024 13:30
@astrobot-houston astrobot-houston mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants