Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db for projects without a seed file or with integrations #10385

Merged
merged 14 commits into from
Mar 11, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Mar 11, 2024

Changes

Testing

  • Added a fixture where an integration configures and seeds tables and no user config is present.
  • Added a fixture where there is no seed file at all.
  • Both tests include testing the build output.

Docs

N/A — bug fix.

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 4760706

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@delucis delucis marked this pull request as ready for review March 11, 2024 16:11
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes. Exseeded my expectations!

@delucis delucis merged commit 38abae4 into main Mar 11, 2024
13 checks passed
@delucis delucis deleted the plt-1781/integrations-without-user-db branch March 11, 2024 19:07
@astrobot-houston astrobot-houston mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants