Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/react - Expose Babel config. #10675

Merged
merged 2 commits into from
Apr 4, 2024
Merged

@astrojs/react - Expose Babel config. #10675

merged 2 commits into from
Apr 4, 2024

Conversation

fightingcat
Copy link
Contributor

Changes

  • Expose Babel config for @astro/react, as it was expected to be a "very high priority" in this proposal.

Testing

It should not break the current tests.

Docs

It wasn't specifically mentioned before.

Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: 8611e91

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Apr 4, 2024
@@ -0,0 +1,5 @@
---
"@astrojs/react": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a new feature this should be minor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I messed up, my first contribution to OSS. It is closed unintentionally, I've discarded my changes and performed again, should I reopen it or what?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, yeah reopening should be fine.

@fightingcat fightingcat closed this Apr 4, 2024
@fightingcat fightingcat reopened this Apr 4, 2024
@matthewp matthewp merged commit 14f1d49 into withastro:main Apr 4, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants