From e1abad6e68cb5b18e067f7b97ec0b8adebee35d7 Mon Sep 17 00:00:00 2001 From: Akshay Petta Date: Fri, 5 Apr 2024 13:05:20 +0100 Subject: [PATCH 1/4] Add disableremoteplayback attribute to VideoHTMLAttributes interface --- packages/astro/astro-jsx.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 869e64d5c919..20cd3a383af9 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -1057,6 +1057,7 @@ declare namespace astroHTML.JSX { poster?: string | undefined | null; width?: number | string | undefined | null; disablepictureinpicture?: boolean | string | undefined | null; + disableremoteplayback?: boolean | string | undefined | null; } // this list is "complete" in that it contains every SVG attribute From 9d3fb9edc8fcdcddad72302bbde6832d4d0bc0b2 Mon Sep 17 00:00:00 2001 From: Akshay Petta Date: Fri, 5 Apr 2024 13:20:49 +0100 Subject: [PATCH 2/4] Move disableremoteplayback from VideoHTMLAttributes to MediaHTMLAttributes --- packages/astro/astro-jsx.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 20cd3a383af9..2592151a1188 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -873,6 +873,7 @@ declare namespace astroHTML.JSX { playsinline?: boolean | string | undefined | null; preload?: string | undefined | null; src?: string | undefined | null; + disableremoteplayback?: boolean | string | undefined | null; } interface MetaHTMLAttributes extends HTMLAttributes { @@ -1057,7 +1058,6 @@ declare namespace astroHTML.JSX { poster?: string | undefined | null; width?: number | string | undefined | null; disablepictureinpicture?: boolean | string | undefined | null; - disableremoteplayback?: boolean | string | undefined | null; } // this list is "complete" in that it contains every SVG attribute From 181571cd684fd986bff1e61f0d1494541e53bf8c Mon Sep 17 00:00:00 2001 From: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Fri, 5 Apr 2024 14:34:54 +0200 Subject: [PATCH 3/4] Create olive-camels-greet.md --- .changeset/olive-camels-greet.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/olive-camels-greet.md diff --git a/.changeset/olive-camels-greet.md b/.changeset/olive-camels-greet.md new file mode 100644 index 000000000000..6fa4a59c289b --- /dev/null +++ b/.changeset/olive-camels-greet.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Adds the `disableremoteplayback` attribute to MediaHTMLAttributes interface From abab924d1e9494d5b2c141d0c19badfc6f3c0c6f Mon Sep 17 00:00:00 2001 From: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Fri, 5 Apr 2024 15:15:15 +0200 Subject: [PATCH 4/4] Update packages/astro/astro-jsx.d.ts --- packages/astro/astro-jsx.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 2592151a1188..08a6c7fba92d 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -873,7 +873,8 @@ declare namespace astroHTML.JSX { playsinline?: boolean | string | undefined | null; preload?: string | undefined | null; src?: string | undefined | null; - disableremoteplayback?: boolean | string | undefined | null; + // https://www.w3.org/TR/remote-playback/#the-disableremoteplayback-attribute + disableRemotePlayback?: boolean | string | undefined | null; } interface MetaHTMLAttributes extends HTMLAttributes {