Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a deprecated method in react integration using SSR: renderToStaticNodeStream #10893

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

Angrigo
Copy link
Contributor

@Angrigo Angrigo commented Apr 27, 2024

Changes

ReactDOMServer.renderToStaticNodeStream() is deprecated.
Use ReactDOMServer.renderToPipeableStream() and wait to pipe until the onAllReady callback has been called instead.

Testing

Tested manually in a project

Docs

Copy link

changeset-bot bot commented Apr 27, 2024

🦋 Changeset detected

Latest commit: 26c954e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Apr 27, 2024
@florian-lefebvre florian-lefebvre linked an issue Apr 28, 2024 that may be closed by this pull request
1 task
@matthewp matthewp merged commit fd7a9ed into withastro:main Apr 30, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: ReactDOMServer.renderToStaticNodeStream() is deprecated.
3 participants