Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): add support for devtools #10929

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 1, 2024

Changes

Testing

Manually in the vue example

Docs

withastro/docs#8150

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: d96dc8b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels May 1, 2024
@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 2, 2024 11:26
@florian-lefebvre florian-lefebvre added this to the 4.8.0 milestone May 2, 2024
@florian-lefebvre florian-lefebvre added the semver: minor Change triggers a `minor` release label May 2, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the same suggestion here as in the docs PR to use the fancier link!

.changeset/thin-rabbits-wait.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changeset for docs, for visibility!

@florian-lefebvre florian-lefebvre merged commit 082abb8 into main May 6, 2024
14 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/vue-devtools branch May 6, 2024 14:02
@astrobot-houston astrobot-houston mentioned this pull request May 6, 2024
@ematipico ematipico modified the milestone: 4.8.0 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants