Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): handle AstroUserError during sync and exports types #10955

Merged
merged 2 commits into from
May 6, 2024

Conversation

florian-lefebvre
Copy link
Member

Changes

  • Handles AstroUserError hint during CC syncing
  • Exports a few content types

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented May 5, 2024

🦋 Changeset detected

Latest commit: d6b40c5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 5, 2024
packages/astro/src/core/sync/index.ts Outdated Show resolved Hide resolved
packages/astro/types/content.d.ts Show resolved Hide resolved
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but I'd also like Erika's review on this if passing the hint from AstroUserError is normal. Seems to be the first place where we handle it specially.

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit odd perhaps, but it's fine with me. The end result is better for the user!

@florian-lefebvre florian-lefebvre merged commit 2978287 into main May 6, 2024
13 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/astro-content-stuff branch May 6, 2024 15:35
@astrobot-houston astrobot-houston mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants