Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unflag Server Islands #11955

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Unflag Server Islands #11955

merged 10 commits into from
Sep 12, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Sep 9, 2024

Changes

  • Removes the need for the experimental.serverIslands option.
  • Errors if the user generates a purely static build and has no adapter.

Testing

  • Updated tests to remove the flag.
  • Added test to ensure an error when no adapter is provided.

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8bc8ce1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Sep 9, 2024
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Sep 9, 2024
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Sep 9, 2024
github-actions[bot]
github-actions bot previously requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp marked this pull request as ready for review September 9, 2024 19:34
sarah11918
sarah11918 reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just taking from the original changeset as another excuse to HYPElight the feature! Many people miss the experimental announcements, so when things get unflagged we usually do repeast!

Here's a suggestion that adds some of the original release notes.

.changeset/strange-sheep-film.md Outdated Show resolved Hide resolved
@matthewp @sarah11918
Update .changeset/strange-sheep-film.md
6e59a44 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
matthewp and others added 3 commits September 10, 2024 09:43
@matthewp matthewp merged commit d813262 into next Sep 12, 2024
14 checks passed
@matthewp matthewp deleted the unflag-si branch September 12, 2024 15:34
@astrobot-houston astrobot-houston mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

@sarah11918 sarah11918 sarah11918 left review comments

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@Princesseuh Princesseuh Princesseuh approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
docs pr pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewp @Princesseuh @sarah11918 @bluwy @florian-lefebvre