Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the generated package.json and tsconfig.json end with a newline. #12186

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

Terfno
Copy link
Contributor

@Terfno Terfno commented Oct 11, 2024

Changes

Add new line at the end of generated package.json and tsconfig.json files.

before

{
  "extends": "astro/tsconfigs/strict"
}

after

{
  "extends": "astro/tsconfigs/strict"
}

Testing

How was this change tested?

  • I add a test case that check the file does end with new line.
  • I run node ./astro/packages/create-astro/create-astro.mjs in my local machine, and check the files end with new line.

Docs

  • Could this affect a user’s behavior? We probably need to update docs!
    • No.
    • Generated files will end with new line.
      /cc @withastro/maintainers-docs for feedback!

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 1d940c8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Oct 11, 2024
@Terfno Terfno marked this pull request as ready for review October 11, 2024 05:38
.changeset/tidy-bugs-yawn.md Outdated Show resolved Hide resolved
@bluwy bluwy merged commit 49c4f64 into withastro:main Oct 11, 2024
12 of 13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants