From 08cc14a333aa5f9eecb46e5a6fe21eb0ae921675 Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Fri, 13 Dec 2024 13:01:53 +0000 Subject: [PATCH 1/3] fix(toolbar): assign label to icons --- .../src/runtime/client/dev-toolbar/apps/audit/index.ts | 2 +- .../astro/src/runtime/client/dev-toolbar/apps/xray.ts | 2 +- packages/astro/src/runtime/client/dev-toolbar/toolbar.ts | 4 ++-- .../src/runtime/client/dev-toolbar/ui-library/icons.ts | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts index a292be3dff82..ea90e0394d92 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts @@ -9,7 +9,7 @@ import { DevToolbarAuditListWindow } from './ui/audit-list-window.js'; import { createAuditUI } from './ui/audit-ui.js'; const icon = - ''; + 'Audit'; export type Audit = { auditedElement: HTMLElement; diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts index f382bef27d5d..173d71f51395 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts @@ -17,7 +17,7 @@ import { } from './utils/window.js'; const icon = - ''; + 'Inspect'; export default { id: 'astro:xray', diff --git a/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts b/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts index 1ab7e9d09b4e..53bdcc6b4ced 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts @@ -416,9 +416,9 @@ export class AstroDevToolbar extends HTMLElement { } getAppTemplate(app: DevToolbarApp) { - return ``; } diff --git a/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts b/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts index bc47970c238c..d15ab3cc9d3a 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts @@ -23,15 +23,15 @@ export function getIconElement( } const icons = { - 'astro:logo': ``, + 'astro:logo': `Menu`, warning: ``, 'arrow-down': - '', - bug: '', + 'Arrow down', + bug: 'Bug', '': '', 'check-circle': '', - gear: '', + gear: 'Settings', lightbulb: '', 'file-search': From b65656275c3f53345106be6093ec9661e5235804 Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Tue, 17 Dec 2024 13:49:31 +0000 Subject: [PATCH 2/3] chore: apply feedback --- .../src/runtime/client/dev-toolbar/apps/audit/index.ts | 2 +- .../astro/src/runtime/client/dev-toolbar/apps/xray.ts | 2 +- .../src/runtime/client/dev-toolbar/ui-library/icons.ts | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts index ea90e0394d92..e6c7777cc19f 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/index.ts @@ -9,7 +9,7 @@ import { DevToolbarAuditListWindow } from './ui/audit-list-window.js'; import { createAuditUI } from './ui/audit-ui.js'; const icon = - 'Audit'; + ''; export type Audit = { auditedElement: HTMLElement; diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts index 173d71f51395..6b1e14340dfc 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/apps/xray.ts @@ -17,7 +17,7 @@ import { } from './utils/window.js'; const icon = - 'Inspect'; + ''; export default { id: 'astro:xray', diff --git a/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts b/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts index d15ab3cc9d3a..f966602531a8 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/ui-library/icons.ts @@ -23,15 +23,15 @@ export function getIconElement( } const icons = { - 'astro:logo': `Menu`, + 'astro:logo': ``, warning: ``, 'arrow-down': - 'Arrow down', - bug: 'Bug', + '', + bug: '', '': '', 'check-circle': '', - gear: 'Settings', + gear: '', lightbulb: '', 'file-search': From 31314a70b342102caadad106878da9e4f0ce62e8 Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Fri, 20 Dec 2024 15:07:19 +0000 Subject: [PATCH 3/3] remove labelled by --- packages/astro/src/runtime/client/dev-toolbar/toolbar.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts b/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts index 53bdcc6b4ced..1ab7e9d09b4e 100644 --- a/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts +++ b/packages/astro/src/runtime/client/dev-toolbar/toolbar.ts @@ -416,9 +416,9 @@ export class AstroDevToolbar extends HTMLElement { } getAppTemplate(app: DevToolbarApp) { - return ``; }