fix: portfolio example JSX error #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2833719 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
requested changes
Jul 10, 2022
| @@ -20,7 +20,7 @@ const projects = (await Astro.glob("./project/**/*.md")) | |||
| s | |||
| most | |||
| recent | |||
| projects' | |||
| projects | |||
There was a problem hiding this comment.
Ah this must have happened in #3862!
Would you mind updating the description attribute so that it says:
description="Learn about Jeanine White's most recent projects"
There was a problem hiding this comment.
Yes, introduced here: https://github.com/withastro/astro/pull/3862/files#diff-a739195a828a765d1e4de3a8e8bf4622ea9b80dc79ac379432843fcc5447a946R23
I've updated the description!
There was a problem hiding this comment.
Oops, totally missed this in my review of that PR, my apologies!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I created a new Astro project with the
portfoliotemplate and noticed a JSX error insrc/pages/projects.astro(an extra'after theprojectsprop), so this PR remove it.I've also noticed that the dev server starts and render the page without any error/bug with this extra
', so this is not really a bug, more of a typo.Testing
No test was added since this concern the portfolio example.
Docs
No doc was changed since this concern the portfolio example.