Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Markdown component to its own package #3986

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 20, 2022

Changes

Testing

  • Moved over as many of the tests as I could.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

🦋 Changeset detected

Latest commit: ce1b36c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
astro Minor
@astrojs/markdown-component Minor
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) feat: markdown Related to Markdown (scope) labels Jul 20, 2022
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jul 20, 2022
@matthewp matthewp marked this pull request as ready for review July 20, 2022 14:31
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP! Looks good but had a few questions.

packages/markdown/component/package.json Show resolved Hide resolved
packages/markdown/component/package.json Show resolved Hide resolved
packages/markdown/component/readme.md Outdated Show resolved Hide resolved
@delucis
Copy link
Member

delucis commented Jul 20, 2022

Not a showstopper, but do we think that @astrojs/markdown is too juicy a package name? Might attract folks when we really want to put them off using this? Maybe even something as explicit as @astrojs/markdown-component or @astrojs/static-markdown-component to make it seem less enticing.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@matthewp matthewp merged commit bccd88f into main Jul 20, 2022
@matthewp matthewp deleted the bye-bye-markdown branch July 20, 2022 20:45
@astrobot-houston astrobot-houston mentioned this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants