Provide correct MIME type for dynamic endpoint routes in dev #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 533496c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #3950
On the dev server, we were only setting MIME types if the route had a pathname, which meant only for static routes. Endpoints like
[filename].svg.tswould be served astext/html. This PR fixes that by building a fake pathname based on the endpoint filename, so that the extension can be used to hint at MIME type.Don’t know if there’s an argument that a production server might not do this for you? I’d assume in all reasonable scenarios, a server will see an
image.svgfile and serve it with the correct MIME type for you.Testing
Added some new tests to the
dev-routing-testto cover MIME types for JSON & SVG endpoints.Docs
Only a bug fix.