Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Create Astro] Improved prompts, template handling, Houston #5088

Merged
merged 12 commits into from
Oct 26, 2022
Merged

[Create Astro] Improved prompts, template handling, Houston #5088

merged 12 commits into from
Oct 26, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Oct 14, 2022 •
edited
Loading

Changes

Introducing your new automated assistant: Houston! 🎉

╭─────╮  Houston:
│ ◠ ◡ ◠  Initiating launch sequence... right... now!
╰─────╯

Since we can't assume terminals on Windows support Unicode 😤, Houston will fallback to an ASCII-only version.

houston-mac-v-win.mov

  • Updates template and TypeScript prompts for clarity and friendliness.

    • Template prompt is more terse, clear
    • TypeScript prompt uses "Hmm... I'm not sure" instead of "No thanks" and the hint has been updated

  • Migrates template copying from degit (unmaintained) to giget for stability.

Testing

Tested manually, create-astro is largely untested due to CI flakiness

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: afc4807

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Oct 14, 2022
@JuanM04
Copy link
Contributor

JuanM04 commented Oct 14, 2022

I love it, it's so cute! There are some tests that are failing, btw, but Huston is awesome

@natemoo-re natemoo-re self-assigned this Oct 14, 2022
tony-sull
tony-sull approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to lose all the extra code needed for degit, the ascii fallback looks nice too (I had been wondering if that would be a Windows problem 📎)

FredKSchott
FredKSchott reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Super excited about removing degit.

Most of my comments were nits, resolve as you see fit. Only one I care more strongly about is the "How would you like to start your new project?" prompt, so I'm happy to chat that through if it helps.

@aFuzzyBear
Copy link
Contributor

HUSTON BOT!!! is lovely dude!!

aFuzzyBear
aFuzzyBear reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻😻😻

FredKSchott
FredKSchott approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some small comments!

@natemoo-re
Copy link
Member Author

Looks like the --typescript test here is flaky, which is not a new problem introduced by this PR. Thoughts on disabling that test? Not sure we're getting much out of it.

@matthewp
Copy link
Contributor

Is it consistently failing? We still have a few flakey tests, but they aren't that flakey, might fail 20% of the time at most. I would expect that they pass on a rerun. Let me look at your changes and see if I can spot something.

@matthewp
Copy link
Contributor

lgtm, you can ignore the check mergability failure, that's a bug in the action.

@natemoo-re natemoo-re merged commit 0408376 into main Oct 26, 2022
@natemoo-re natemoo-re deleted the feat/create-astro-improvements branch October 26, 2022 15:13
@astrobot-houston astrobot-houston mentioned this pull request Oct 26, 2022
Merged
@mrienstra mrienstra mentioned this pull request Nov 3, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aFuzzyBear aFuzzyBear aFuzzyBear left review comments

@tony-sull tony-sull tony-sull approved these changes

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees

@natemoo-re natemoo-re

Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@natemoo-re @JuanM04 @aFuzzyBear @matthewp @FredKSchott @tony-sull