-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for other markdown file extensions #5164
Merged
matthewp
merged 20 commits into
withastro:main
from
MoustaphaDev:add-dot-markdown-file-extension-support
Oct 26, 2022
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2b4dabb
fix: add `.markdown ` file extension support
MoustaphaDev 56ee093
test: add test case
MoustaphaDev acb3adf
chore: adds changeset
MoustaphaDev 132cef3
test: move test and fixture to relevant locations
MoustaphaDev 4affcb6
test: update test
MoustaphaDev 2b62ad1
feat: add multiple markdown file extension support
MoustaphaDev c11e9fc
feat: add module declaration for different markdown file extensions
MoustaphaDev 36d1eb6
refactor: markdown module declarations
MoustaphaDev 2bddbfb
Merge branch 'main' into add-dot-markdown-file-extension-support
MoustaphaDev 77659ed
fix: add .js extension to module imports
MoustaphaDev f2fc6ff
test: update test
MoustaphaDev 992c601
chore: update changeset
MoustaphaDev d6a55d2
chore: update changeset
MoustaphaDev abb1214
test: add new test cases
MoustaphaDev 90323c3
Merge branch 'main' into add-dot-markdown-file-extension-support
MoustaphaDev d5c2f80
test: update tests
MoustaphaDev 7200a69
fix: correct typo
MoustaphaDev ff0224d
Merge branch 'main' into add-dot-markdown-file-extension-support
MoustaphaDev c73d62c
Merge branch 'main' into add-dot-markdown-file-extension-support
MoustaphaDev 85b625d
Merge branch 'main' into add-dot-markdown-file-extension-support
MoustaphaDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
'astro': minor | ||
'@astrojs/rss': patch | ||
--- | ||
|
||
Add support for markdown files with the following extensions: | ||
- `.markdown` | ||
- `.mdown` | ||
- `.mkdn` | ||
- `.mkd` | ||
- `.mdwn` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,12 @@ | ||
// process.env.PACKAGE_VERSION is injected when we build and publish the astro package. | ||
export const ASTRO_VERSION = process.env.PACKAGE_VERSION ?? 'development'; | ||
|
||
// possible extensions for markdown files | ||
export const SUPPORTED_MARKDOWN_FILE_EXTENSIONS = [ | ||
'.markdown', | ||
'.mdown', | ||
'.mkdn', | ||
'.mkd', | ||
'.mdwn', | ||
'.md', | ||
] as const; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would cause a patch for the rss package, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's file.