Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/node standalone for windows system #5207

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

BeanWei
Copy link

@BeanWei BeanWei commented Oct 27, 2022

Changes

Testing

  • tested with the examples at my local

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

🦋 Changeset detected

Latest commit: f823a3d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 27, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @BeanWei! This make sense to me and seems to be the correct way to use the send() API. Have a small review below but the rest looks good.

.changeset/metal-boxes-compare.md Outdated Show resolved Hide resolved
@BeanWei BeanWei requested a review from bluwy October 27, 2022 09:15
@bluwy bluwy merged commit c203a5c into withastro:main Oct 27, 2022
@bluwy
Copy link
Member

bluwy commented Oct 27, 2022

Thanks!

@astrobot-houston astrobot-houston mentioned this pull request Oct 27, 2022
@BeanWei BeanWei deleted the fix/node-standalone-windows branch October 27, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples/ssr is not working
2 participants