Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration config hook on astro sync #6238

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Run integration config hook on astro sync #6238

merged 5 commits into from
Feb 14, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Run astro:config:setup hooks on astro sync. This was preventing preact-compat from mounting in the docs repo
  • Refactor: move sync out of cli/ into core/

Testing

Docs

@bholmesdev bholmesdev marked this pull request as ready for review February 13, 2023 22:06
@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f005efc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 13, 2023
delucis
delucis reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds plausible but haven’t tested so I’ll leave it to more expert eyes to approve. This is an appreciation review instead.

🎶 Be running up that hook
Be running up and building (the docs site) 🎶

@bholmesdev bholmesdev merged commit deacd54 into main Feb 14, 2023
@bholmesdev bholmesdev deleted the fix/astro-sync-missing-config branch February 14, 2023 14:26
@astrobot-houston astrobot-houston mentioned this pull request Feb 14, 2023
Merged
@natemoo-re natemoo-re mentioned this pull request Feb 24, 2023
Closed
1 task
@bluwy bluwy mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bholmesdev @delucis @bluwy